I wanna make this code better

May 7th, 2008, 12:33 pm

Hi,

I just wrote this and it seems a little long. As if you could make it shorter. Anywayif anyone can help shorten this code, I'd like to learn.

Line number On/Off

Code: Select all

1.  
2. var i:Number = 1;
3.  
4. function DoRandom() {
5. var target_x = home_x - content_mc["section_"+i]._x;
6. content_mc.slideTo( target_x, "0", 2 );
7. i++;
8. if(i==6) clearInterval(intervalID);
9. if(i==6) var target_x = home_x-content_mc.section_0._x;
10.     content_mc.slideTo(target_x,"0",2);
11.     if(i==1) var alphaT:Tween = new Tween(b_0, "_alpha", Regular.easeOut, 50, 70, 1, true);
12.     if(i==2) var alphaT:Tween = new Tween(b_0, "_alpha", Regular.easeOut, 50, 50, 1, true);
13.     if(i==2) var alphaT:Tween = new Tween(b_1, "_alpha", Regular.easeOut, 50, 70, 1, true);
14.     if(i==3) var alphaT:Tween = new Tween(b_1, "_alpha", Regular.easeOut, 50, 50, 1, true);
15.     if(i==3) var alphaT:Tween = new Tween(b_2, "_alpha", Regular.easeOut, 50, 70, 1, true);
16.     if(i==4) var alphaT:Tween = new Tween(b_3, "_alpha", Regular.easeOut, 50, 70, 1, true);
17.     if(i==4) var alphaT:Tween = new Tween(b_2, "_alpha", Regular.easeOut, 50, 50, 1, true);
18.     if(i==5) var alphaT:Tween = new Tween(b_4, "_alpha", Regular.easeOut, 50, 70, 1, true);
19.     if(i==5) var alphaT:Tween = new Tween(b_3, "_alpha", Regular.easeOut, 50, 50, 1, true);
20.     if(i==6) var alphaT:Tween = new Tween(b_4, "_alpha", Regular.easeOut, 50, 50, 1, true);
21.     if(i==6) var alphaT:Tween = new Tween(b_0, "_alpha", Regular.easeOut, 50, 70, 1, true);
22. }  
23.  
24. var intervalID = setInterval(DoRandom, 4000);

Thanks,

May 7th, 2008, 4:21 pm

well you could use a case statement. Thats a lot easier than a your long list of if's. You could also write the alphaT line once and use variables to fill in the arguements. IE

Line number On/Off

Code: Select all

1. var targ="b_4";

etc