commenting php code

Could anyone be kind enough to tell me what's wrong with this code.

thanks

You can't insert conditional blocks as part of a string itself; you should use ternary conditionals if that's what you're trying to do:

Thanks a lot.

I like to use printf for complex printing/echos like that.



It lets me keep the HTML together and makes it easier to remember exactly what that section is for. Having all of the HTML together with simple tokens also makes it easier to find with something such as grep or findstr down the road, as well as makes it easier to add to in the future.

Something you might notice is that I'm using numbered tokens even though I only have two tokens. At first it might seem that there's no need to use numbered tokens because two tokens is easy enough to keep track of, but what if I want to add/modify something between existing tokens in the foture ?

For instance, what if the selected attribute were to become dependent on a condition for whatever reason in the future ?



Another thing you might notice is that I've got a " //2 " in there. I do this periodically throughout my list of tokens so that it's easier to keep track of which tokens go with which number and so I can quickly determine which number to use if I need to add a new token.

// Edit -- Though, now that I actually pay attention to value of the tokens, I would probably write that as follows. Again, a nice utilization of the numbered tokens.