no image from mysql table, just binary data.help?

i have a forum im making . and im trying to make the picture thats stored in the user_table to show up..but all i get is binary data ...


the code for viewing the entries is here:



i have 2 tables, one called :

mb_users
http://nuhorizononline.web.aplus.net/mb_user.JPG


and

mb_entries:
http://nuhorizononline.web.aplus.net/mb_entries.JPG


any help?

Thanks,

-Mike[/url]

I understand what you're trying to do, but I don't see how you can expect the code you posted to do anything even remotely similar. Before I get into your actual problem though, there are a couple other issues you need to look into.

Whitespace is not always a good thing. You don't need multiple lines of nothing but white space and actual spaces breaking your code all up. The idea is to use it (in moderation) to group common functionality together. If you're using some code editor that outputs stuff that looks like this, go get PSPad (http://www.pspad.com)

You shouldn't be using double quotes on your HTML string. In that entire thing, you're only outputting 4 variables, all of which reside in a associative array. A better way to write it would be something like:

Since you're only writing a very few variables into a relatively large HTML block, and even better way would be to escape out of PHP entirely (which I show below).

There's hardly ever a reason to use mysql_fetch_array(). 9 times out of 10, including this one, what you really need is mysql_fetch_assoc(). The difference is that mysql_fetch_array() creates an array that's twice as large as the data because it creates keys by column name as well as by number. This doesn't have much effect on a small site, but can make a difference when something running on your code gets popular.

Never, never, never use single character variable names unless it's the $i in a for() (for() being something that you should probably be using a foreach() in place of anyway). The standard for a database result handler is "$result". Using single character variable names does not make your code look more "professional" in any way, shape or form and it's not that hard to think of a real name and press a few extra keys.

Here's your code, cleaned up:

I notice you have nothing in the image src here. This would explain why you're seeing nothing at all. However, whenever you're pulling binary data out of a database, you need to store the mime type and the file size and you have to have a separate script whose sole purpose is to pull the image out of the database and send it to the page. Something like:



To display the image on the page, you just call the above script as though it were an image:



HTH

thanks! that will help..

my upload function was this..

if ($_REQUEST[completed] == 1) {

move_uploaded_file($_FILES['imagefile']['tmp_name'],"latest.img");
$instr = fopen("latest.img","rb");
$image = addslashes(fread($instr,filesize("latest.img")));


..it worked...but now since you said i have to get the size and type.. i dont know how to incorporate that into the upload function...

i've seen other upload functions but they dont work lol for me at at least...

could u guide me to a good upload technique?

hey the upload works now ...

i just have a question about my image..


here's the view_entry.php page i have..



$query = "SELECT * FROM mb_entries, mb_users WHERE mb_entries.username = mb_users.user";
$result = mysql_query($query);


// if the guestbook is empty show a message
if(mysql_num_rows($result) == 0)
{
?>
<p><br><br> <font color="white">Message Board is empty. </font> </p>
<?php
}
else
{

while( $row = mysql_fetch_assoc($result) ){

?><br><br>

<table border=0 style="background-color:black; border:1px solid whit e; width:400px">
<tr>
<td align='left'> <img src="view_picture.php?id={$row['user_id']}"> </td>
<td>Title: <?php echo $row['title']; ?><br>
Posted by: <b><?php echo $row['username']; ?></b>
<br><Br>
Message: <?php echo $row['entry']; ?>
</td>
</tr>
</table>

<?php
}

}






and here's my view picture :


import_request_variables("gP");

if(isset($_GET['id']))
{
// if id is set then get the file with the id from database

;
$id = $_GET['id'];

$query = "SELECT img_title, imgdata, image_type, image_size " .
"FROM mb_users WHERE user_id = '$id'";

$result = mysql_query($query) or die('Error, query failed');
list($fileName, $content, $fileType, $fileSize) = mysql_fetch_array($result);

header("Content-length: $fileSize");
header("Content-type: $fileType");
header("Content-Disposition: attachment; filename=$fileName");
echo $content;

exit;
}



in my messageboad, i just have a red x in my picture box..i dont think its getting the image...

could u help me out with that?

my message board is at http://www.nuhorizononline.com/messageB ... eBoard.php

thanks.

Never use user submitted values directly in the query string like that. At the very least, you should be assigning the value to the variable using addslashes(). Since the id is a number, you'd do better to use intval(). You can look both of these up here (a good idea would be to bookmark this page): http://www.php.net/quickref.php

As for dealing with your file uploads: http://us2.php.net/features.file-upload
The $_FILES array contains the mime type of the uploaded file. There's a basic tutorial for doing all of this here: http://codewalkers.com/tutorials/35/1.html

thanks..the upload works fine ..

here's a quick question..

regarding my image in the user table..

i can grab the user_id, but it wont display the image ..

look at this to see what im talking about. http://www.nuhorizononline.com/viewPicture.php

the user_table has:

user_id, first_name, last_name...,img_title, image_size, image_type, imgdata

sorry, i fixed it..

check it out now...

when i click on the link, it grabs the user_id but outputs no image when i call for it in the download2.php

in IE it shows me binary data

in firefox it shows me: http://www.nuhorizononline.com/download2.php?id=40

any suggestions?

That's giving a header of Content-Type: image/pjpeg, change it to image/jpeg

changing it to image/jpeg doesnt do anything to it...

check it out again..

http://www.nuhorizononline.com/viewPicture.php


my code for download2.php is:



it doesn't seem to read any of the fields on the download2.php page... on viewPicture.php it prints out the username and first name, etc. though.

Where's your Content-Disposition header?

Try this

hey! that works, i save the image but when i open it there's no image , it just says no preview available..

You still have something not quite right, post the current contents of this script:
http://www.nuhorizononline.com/download2.php
Be sure you're changing your database username and password for the sake of security.

Make sure you're storing the file's binary, size, type and name in the database and are able to call them back out. You might also post your upload script so I can see how you're doing things there too.

this whole thing is so i can be able to grab the image from the user table and display it on the message board on this site im making... upload form can be looked at http://www.nuhorizononline.com/messageB ... ter_mb.php (it's not fully validated yet, but it works and i got the image to upload as well)

here's the php script for the upload :




my user table is shown here:

http://nuhorizononline.web.aplus.net/userstable.JPG




my download2.php script is here: