An unexpected Warning of mysql_fetch_array() in my php file

May 17th, 2007, 11:52 am

Hi!
i'm working on a simple site. I have already write some php pages like login.php, register.php.....
In my pages i have included the pages header.html, left.html, right.html and footer.html.
The left.html page is a simple select query which is used for my left menu.
When i run a page wich include a form (like login.php), and the form is not submitted correctly, i have an error on the left.html page! The error is:
mysql_fetch_array(): supplied argument is not a valid MySQL result resource in left.html (in the two bold lines in the code)
If the form submitted correctly i don't have any warning. If it is not, the previous error displayed instead of my menu (left.htm)
I can't understand what is going on...
please help!

left.html code:

Code: [ Download ] [ Select ]

<!--left.html-->
<table border="0" cellspacing="0" cellpadding="0" width="150">
<tr>
<td class="minfo" style=" background: url('./images/bckbanner.gif') no-repeat; " height="35">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Ταινίες</td>
</tr>
<tr>
<td align="left">
<table background = "./images/banner.gif" valign="bottom" width="150" border="0">


<?php
require_once ('../mysql_connect.php'); // Connect to the db.
$query = "SELECT categories.category AS category, categories.cat_id AS id
FROM categories
GROUP BY id";
$result = @mysql_query ($query); // Run the query.
[b]while ($row = mysql_fetch_array ($result, MYSQL_ASSOC)) {[/b]
// Start defining the URL.
$url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
// Check for a trailing slash.
if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
$url = substr ($url, 0, -1); // Chop off the slash.
}
// Add the page.
$url .= '/movies.php';
$cat= "-" . $row[category];
$url .= '?name=' . urldecode("$row[id] $cat");
// Display each record.
if ($row[id] != "12" and $row[id] != "13" and $row[id] != "14" ) {
echo " <tr><td><a href='$url'>&nbsp;&nbsp;&nbsp;&nbsp;$row[category]</a></td> </tr>";
}
}// End of while loop.
?>

<tr>
<td height="3" background="./images/btitle.gif" valign="bottom" width="150"></td>
</tr>
<tr>
<td height="3" valign="bottom" width="150"></td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="mbanner" bgcolor="#ffffff" height="4">&nbsp;</td>
</tr>
<tr>
<td class="minfo" style=" background: url('./images/bckbanner.gif') no-repeat; " height="35">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Παιχνίδια</td>
</tr>
<tr>
<td align="left">
<table background = "./images/banner.gif" valign="bottom" width="150" border="0">
<?php
require_once ('../mysql_connect.php'); // Connect to the db.
$query = "SELECT categories.category AS category, categories.cat_id AS id
FROM categories
WHERE
(categories.cat_id=12 or categories.cat_id=13 or categories.cat_id=14)
GROUP BY id";
$result = @mysql_query ($query); // Run the query.
[b]while ($row = mysql_fetch_array ($result, MYSQL_ASSOC)) {[/b]
// Start defining the URL.
$url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
// Check for a trailing slash.
if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
$url = substr ($url, 0, -1); // Chop off the slash.
}
// Add the page.
$url .= '/movies.php';
$cat= "-" . $row[category];
$url .= '?name=' . urldecode("$row[id] $cat");
// Display each record.
echo " <tr><td><a href='$url'>&nbsp;&nbsp;&nbsp;&nbsp;$row[category]</a></td> </tr>";

}// End of while loop.
?>
<tr>
<td height="3" background="./images/btitle.gif" valign="bottom" width="150"></td>
</tr>
<tr>
<td height="3" valign="bottom" width="150"></td>
</tr>
</table>
</td>
</tr>
</table>
<!-- Content starts here! -->

1. <!--left.html-->
2. <table border="0" cellspacing="0" cellpadding="0" width="150">
3. <tr>
4. <td class="minfo" style=" background: url('./images/bckbanner.gif') no-repeat; " height="35">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Ταινίες</td>
5. </tr>
6. <tr>
7. <td align="left">
8. <table background = "./images/banner.gif" valign="bottom" width="150" border="0">
11. <?php
12. require_once ('../mysql_connect.php'); // Connect to the db.
13. $query = "SELECT categories.category AS category, categories.cat_id AS id
14. FROM categories
15. GROUP BY id";
16. $result = @mysql_query ($query); // Run the query.
17. [b]while ($row = mysql_fetch_array ($result, MYSQL_ASSOC)) {[/b]
18. // Start defining the URL.
19. $url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
20. // Check for a trailing slash.
21. if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
22. $url = substr ($url, 0, -1); // Chop off the slash.
23. }
24. // Add the page.
25. $url .= '/movies.php';
26. $cat= "-" . $row[category];
27. $url .= '?name=' . urldecode("$row[id] $cat");
28. // Display each record.
29. if ($row[id] != "12" and $row[id] != "13" and $row[id] != "14" ) {
30. echo " <tr><td><a href='$url'>&nbsp;&nbsp;&nbsp;&nbsp;$row[category]</a></td> </tr>";
31. }
32. }// End of while loop.
33. ?>
35. <tr>
36. <td height="3" background="./images/btitle.gif" valign="bottom" width="150"></td>
37. </tr>
38. <tr>
39. <td height="3" valign="bottom" width="150"></td>
40. </tr>
41. </table>
42. </td>
43. </tr>
44. <tr>
45. <td class="mbanner" bgcolor="#ffffff" height="4">&nbsp;</td>
46. </tr>
47. <tr>
48. <td class="minfo" style=" background: url('./images/bckbanner.gif') no-repeat; " height="35">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Παιχνίδια</td>
49. </tr>
50. <tr>
51. <td align="left">
52. <table background = "./images/banner.gif" valign="bottom" width="150" border="0">
53. <?php
54. require_once ('../mysql_connect.php'); // Connect to the db.
55. $query = "SELECT categories.category AS category, categories.cat_id AS id
56. FROM categories
57. WHERE
58. (categories.cat_id=12 or categories.cat_id=13 or categories.cat_id=14)
59. GROUP BY id";
60. $result = @mysql_query ($query); // Run the query.
61. [b]while ($row = mysql_fetch_array ($result, MYSQL_ASSOC)) {[/b]
62. // Start defining the URL.
63. $url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
64. // Check for a trailing slash.
65. if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
66. $url = substr ($url, 0, -1); // Chop off the slash.
67. }
68. // Add the page.
69. $url .= '/movies.php';
70. $cat= "-" . $row[category];
71. $url .= '?name=' . urldecode("$row[id] $cat");
72. // Display each record.
73. echo " <tr><td><a href='$url'>&nbsp;&nbsp;&nbsp;&nbsp;$row[category]</a></td> </tr>";
75. }// End of while loop.
76. ?>
77. <tr>
78. <td height="3" background="./images/btitle.gif" valign="bottom" width="150"></td>
79. </tr>
80. <tr>
81. <td height="3" valign="bottom" width="150"></td>
82. </tr>
83. </table>
84. </td>
85. </tr>
86. </table>
87. <!-- Content starts here! -->

login.php code:

Code: [ Download ] [ Select ]

<?php # login.php
// Send NOTHING to the Web browser prior to the session_start() line!

// Check if the form has been submitted.
if (isset($_POST['submitted'])) {

require_once ('../mysql_connect.php'); // Connect to the db.

$errors = array(); // Initialize error array.

// Check for an email address.
if (empty($_POST['email'])) {
$errors[] = 'email address';
} else {
$email = escape_data($_POST['email']);
}

// Check for a password.
if (empty($_POST['password'])) {
$errors[] = 'password';
} else {
$password = escape_data($_POST['password']);
}

if (empty($errors)) { // If everything's OK.

/* Retrieve the user_id and first_name for
that email/password combination. */
$query = "SELECT user_id, firstName FROM users WHERE email='$email' AND password=md5('$password')";
$result = @mysql_query ($query); // Run the query.
$row = mysql_fetch_array ($result, MYSQL_NUM); // Return a record, if applicable.

if ($row) { // A record was pulled from the database.

// Set the session data & redirect.
session_name ('YourVisitID');
session_start();
$_SESSION['user_id'] = $row[0];
$_SESSION['firstName'] = $row[1];
$_SESSION['email'] = $row[2];
$_SESSION['agent'] = md5($_SERVER['HTTP_USER_AGENT']);

// Redirect the user to the loggedin.php page.
// Start defining the URL.
$url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
// Check for a trailing slash.
if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
$url = substr ($url, 0, -1); // Chop off the slash.
}
// Add the page.
$url .= '/loggedin.php';

header("Location: $url");
exit(); // Quit the script.

} else { // No record matched the query.
$errors[] = ' <br /> Δεν υπάρχει τέτοιος συνδυασμός e-mail και password';
}

} // End of if (empty($errors)) IF.

mysql_close(); // Close the database connection.

} else { // Form has not been submitted.

$errors = NULL;

} // End of the main Submit conditional.

// Begin the page now.
?>
<table width="940" height="100%" border="0" cellpadding="0" cellspacing="0" align="center">
<tr>
<td>
<?php
// Set the page title and include the HTML header.
$page_title = 'Login';
include ('./includes/header.html');
?>
</td>
</tr>
<tr><td>
<table width="940" height="100%" border="0" cellpadding="0" cellspacing="0" align="left">
<tr><td height="3" colspan="2">&nbsp;</td></tr>
<tr>
<td valign="top">
<?php // Include the HTML left file.
include ('./includes/left.html');
?>
</td>
<td valign="top">
<table width="784" border="0" cellspacing="0" cellpadding="0" align="center">
<tr>
<td align="left" valign="top" width="100%">
<table class="mtable" border="0" cellpadding="0" cellspacing="0" width="100%" valign="top">
<tr>
<td height="14" class="minfot" background="./images/btitle.gif" cellpadding="0" cellspacing="0" valign="middle">&nbsp;&nbsp;&nbsp;Login</td>
<td height="14" class="minfot" background="./images/btitle.gif" cellpadding="0" cellspacing="0" align="right" valign="middle">Guest&nbsp;</td>
</tr>
<tr>
<td colspan="2">
<form action="login.php" method="post">
<table align="center">
<tr>
<td class="minfos">&nbsp;</td>
<td></td>
</tr>
<tr>
<td class="minfos">Email Address: </td>
<td><input type="text" name="email" size="20" maxlength="40" class="inpblue2" /></td>
</tr>
<tr>
<td class="minfos">Password: </td>
<td><input type="password" name="password" size="20" maxlength="20" class="inpblue" /></td>
</tr>
<tr>
<td class="minfos">&nbsp;</td>
<td class="minfos" align="center">
<input type="submit" name="submit" value="Login" class="inpblue" />
<input type="hidden" name="submitted" value="TRUE" />
</td>
</tr>
<tr>
<td>&nbsp;</td>
<td class="minfos2" align="center"><br>
<a href="remind.php">Ξέχασα τoν κωδικό μου</a>
</td>
</tr>
<tr>
<td>&nbsp;</td>
<td class="minfos2" align="center"><br>
<a href="register.php">Eγγραφή</a>
</td>
</tr>
</form>
<tr>
<td colspan="2" >
<?php
if (!empty($errors)) { // Print any error messages.
echo '<p class="text"><b>ΠΡΟΣΟΧΗ!</b></p>
<p class="text" >Δεν έχετε συμπληρώσει σωστά τα πεδία &nbsp; <p />';
foreach ($errors as $msg) { // Print each error.
    echo " <font class='text'>$msg &nbsp; </font>";
}
echo '<p class="text">Προσπαθείστε ξανά!</p>';
}
// Create the form.
?>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
<td class="mrtable" valign="top" width="120">
<?php // Include the HTML right file.
include ('./includes/right.html');
?>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td colspan="2">
<?php // Include the HTML footer file.
include ('./includes/footer.html');
?>
</td>
</tr>
</table>
</td></tr>
</table>

1. <?php # login.php
2. // Send NOTHING to the Web browser prior to the session_start() line!
4. // Check if the form has been submitted.
5. if (isset($_POST['submitted'])) {
7. require_once ('../mysql_connect.php'); // Connect to the db.
9. $errors = array(); // Initialize error array.
11. // Check for an email address.
12. if (empty($_POST['email'])) {
13. $errors[] = 'email address';
14. } else {
15. $email = escape_data($_POST['email']);
16. }
18. // Check for a password.
19. if (empty($_POST['password'])) {
20. $errors[] = 'password';
21. } else {
22. $password = escape_data($_POST['password']);
23. }
25. if (empty($errors)) { // If everything's OK.
27. /* Retrieve the user_id and first_name for
28. that email/password combination. */
29. $query = "SELECT user_id, firstName FROM users WHERE email='$email' AND password=md5('$password')";
30. $result = @mysql_query ($query); // Run the query.
31. $row = mysql_fetch_array ($result, MYSQL_NUM); // Return a record, if applicable.
33. if ($row) { // A record was pulled from the database.
35. // Set the session data & redirect.
36. session_name ('YourVisitID');
37. session_start();
38. $_SESSION['user_id'] = $row[0];
39. $_SESSION['firstName'] = $row[1];
40. $_SESSION['email'] = $row[2];
41. $_SESSION['agent'] = md5($_SERVER['HTTP_USER_AGENT']);
43. // Redirect the user to the loggedin.php page.
44. // Start defining the URL.
45. $url = 'http://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);
46. // Check for a trailing slash.
47. if ((substr($url, -1) == '/') OR (substr($url, -1) == '\\') ) {
48. $url = substr ($url, 0, -1); // Chop off the slash.
49. }
50. // Add the page.
51. $url .= '/loggedin.php';
53. header("Location: $url");
54. exit(); // Quit the script.
56. } else { // No record matched the query.
57. $errors[] = ' <br /> Δεν υπάρχει τέτοιος συνδυασμός e-mail και password';
58. }
60. } // End of if (empty($errors)) IF.
62. mysql_close(); // Close the database connection.
64. } else { // Form has not been submitted.
66. $errors = NULL;
68. } // End of the main Submit conditional.
70. // Begin the page now.
71. ?>
72. <table width="940" height="100%" border="0" cellpadding="0" cellspacing="0" align="center">
73. <tr>
74. <td>
75. <?php
76. // Set the page title and include the HTML header.
77. $page_title = 'Login';
78. include ('./includes/header.html');
79. ?>
80. </td>
81. </tr>
82. <tr><td>
83. <table width="940" height="100%" border="0" cellpadding="0" cellspacing="0" align="left">
84. <tr><td height="3" colspan="2">&nbsp;</td></tr>
85. <tr>
86. <td valign="top">
87. <?php // Include the HTML left file.
88. include ('./includes/left.html');
89. ?>
90. </td>
91. <td valign="top">
92. <table width="784" border="0" cellspacing="0" cellpadding="0" align="center">
93. <tr>
94. <td align="left" valign="top" width="100%">
95. <table class="mtable" border="0" cellpadding="0" cellspacing="0" width="100%" valign="top">
96. <tr>
97. <td height="14" class="minfot" background="./images/btitle.gif" cellpadding="0" cellspacing="0" valign="middle">&nbsp;&nbsp;&nbsp;Login</td>
98. <td height="14" class="minfot" background="./images/btitle.gif" cellpadding="0" cellspacing="0" align="right" valign="middle">Guest&nbsp;</td>
99. </tr>
100. <tr>
101. <td colspan="2">
102. <form action="login.php" method="post">
103. <table align="center">
104. <tr>
105. <td class="minfos">&nbsp;</td>
106. <td></td>
107. </tr>
108. <tr>
109. <td class="minfos">Email Address: </td>
110. <td><input type="text" name="email" size="20" maxlength="40" class="inpblue2" /></td>
111. </tr>
112. <tr>
113. <td class="minfos">Password: </td>
114. <td><input type="password" name="password" size="20" maxlength="20" class="inpblue" /></td>
115. </tr>
116. <tr>
117. <td class="minfos">&nbsp;</td>
118. <td class="minfos" align="center">
119. <input type="submit" name="submit" value="Login" class="inpblue" />
120. <input type="hidden" name="submitted" value="TRUE" />
121. </td>
122. </tr>
123. <tr>
124. <td>&nbsp;</td>
125. <td class="minfos2" align="center"><br>
126. <a href="remind.php">Ξέχασα τoν κωδικό μου</a>
127. </td>
128. </tr>
129. <tr>
130. <td>&nbsp;</td>
131. <td class="minfos2" align="center"><br>
132. <a href="register.php">Eγγραφή</a>
133. </td>
134. </tr>
135. </form>
136. <tr>
137. <td colspan="2" >
138. <?php
139. if (!empty($errors)) { // Print any error messages.
140. echo '<p class="text"><b>ΠΡΟΣΟΧΗ!</b></p>
141. <p class="text" >Δεν έχετε συμπληρώσει σωστά τα πεδία &nbsp; <p />';
142. foreach ($errors as $msg) { // Print each error.
143.     echo " <font class='text'>$msg &nbsp; </font>";
144. }
145. echo '<p class="text">Προσπαθείστε ξανά!</p>';
146. }
147. // Create the form.
148. ?>
149. </td>
150. </tr>
151. </table>
152. </td>
153. </tr>
154. </table>
155. </td>
156. <td class="mrtable" valign="top" width="120">
157. <?php // Include the HTML right file.
158. include ('./includes/right.html');
159. ?>
160. </td>
161. </tr>
162. </table>
163. </td>
164. </tr>
165. <tr>
166. <td colspan="2">
167. <?php // Include the HTML footer file.
168. include ('./includes/footer.html');
169. ?>
170. </td>
171. </tr>
172. </table>
173. </td></tr>
174. </table>

mysql_connect.php code:

Code: [ Download ] [ Select ]

<?php # mysql_connect.php

// This file contains the database access information.
// This file also establishes a connection to MySQL and selects the database.
// This file also defines the escape_data() function.

// Set the database access information as constants.
DEFINE ('DB_USER', 'xxxxxxxxxx');
DEFINE ('DB_PASSWORD', 'xxxxxxxxxx');
DEFINE ('DB_HOST', 'xxxxxxxxxxxxxxx');
DEFINE ('DB_NAME', 'xxxxxxxxxx');

// Make the connection.
$dbc = @mysql_connect (DB_HOST, DB_USER, DB_PASSWORD) OR die ('Could not connect to MySQL: ' . mysql_error() );

// Select the database.
@mysql_select_db (DB_NAME) OR die ('Could not select the database: ' . mysql_error() );

mysql_query('set names greek;');

// Create a function for escaping the data.
function escape_data ($data) {

// Address Magic Quotes.
if (ini_get('magic_quotes_gpc')) {
$data = stripslashes($data);
}

// Check for mysql_real_escape_string() support.
if (function_exists('mysql_real_escape_string')) {
global $dbc; // Need the connection.
$data = mysql_real_escape_string (trim($data), $dbc);
} else {
$data = mysql_escape_string (trim($data));
}

// Return the escaped value.
return $data;

} // End of function.
?>

1. <?php # mysql_connect.php
3. // This file contains the database access information.
4. // This file also establishes a connection to MySQL and selects the database.
5. // This file also defines the escape_data() function.
7. // Set the database access information as constants.
8. DEFINE ('DB_USER', 'xxxxxxxxxx');
9. DEFINE ('DB_PASSWORD', 'xxxxxxxxxx');
10. DEFINE ('DB_HOST', 'xxxxxxxxxxxxxxx');
11. DEFINE ('DB_NAME', 'xxxxxxxxxx');
13. // Make the connection.
14. $dbc = @mysql_connect (DB_HOST, DB_USER, DB_PASSWORD) OR die ('Could not connect to MySQL: ' . mysql_error() );
16. // Select the database.
17. @mysql_select_db (DB_NAME) OR die ('Could not select the database: ' . mysql_error() );
19. mysql_query('set names greek;');
21. // Create a function for escaping the data.
22. function escape_data ($data) {
24. // Address Magic Quotes.
25. if (ini_get('magic_quotes_gpc')) {
26. $data = stripslashes($data);
27. }
29. // Check for mysql_real_escape_string() support.
30. if (function_exists('mysql_real_escape_string')) {
31. global $dbc; // Need the connection.
32. $data = mysql_real_escape_string (trim($data), $dbc);
33. } else {
34. $data = mysql_escape_string (trim($data));
35. }
37. // Return the escaped value.
38. return $data;
40. } // End of function.
41. ?>

May 17th, 2007, 10:58 pm

========================================
$result = @mysql_query ($query); // Run the query.
while ($row = mysql_fetch_array ($result, MYSQL_ASSOC)) {
========================================
I think the problem is that $result maybe not an array sometimes, try to remove the @ sign from mysql_query, and check the result

May 17th, 2007, 10:59 pm

$result = mysql_query('SELECT * WHERE 1=1');
if (!$result) {
die('Invalid query: ' . mysql_error());
}

May 17th, 2007, 11:39 pm

try:
$qry = 'SELECT * WHERE 1=1';
$result = mysql_query($qry) or die(mysql_error($qry));
if(mysql_num_rows($result) > 0)
{
if (!$result) {
die('Invalid query: ' . mysql_error());
}
}
else
{
echo "no result.";
}

May 18th, 2007, 4:36 pm

You have right. i did this and the error message changed to:
Query failed: Access denied for user.....

But i can't understand why...
the same code run ok in all other pages which include the left.html.
Also it run ok if the form in the login.php submitted correctly...
i'm so confused...

May 19th, 2007, 1:58 am

I think you are including the left after you close the connection
mysql_close(); // Close the database connection.

and in left you specified : require_once ('../mysql_connect.php');
because you already included the file, it will not be included again.

Warning: i wouldnt write PHP files with .html, any1 can see your source

May 21st, 2007, 8:48 am

you have absolutelly right.
i haven't realized that. I think that just now understand the difference between require() and require_once().
thank you very much...